MaxGekk commented on code in PR #40126:
URL: https://github.com/apache/spark/pull/40126#discussion_r1151062611
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/ResolveAliasesSuite.scala:
##########
@@ -88,4 +94,46 @@ class ResolveAliasesSuite extends AnalysisTest {
checkAliasName(t1.select(DateSub(Literal(Date.valueOf("2021-01-18")),
Literal(null))),
"date_sub(DATE '2021-01-18', NULL)")
}
+
+ test("SPARK-40822: Stable derived column aliases") {
+ withSQLConf(SQLConf.STABLE_DERIVED_COLUMN_ALIAS_ENABLED.key -> "true") {
+ Seq(
+ // Literals
+ "' 1'" -> "' 1'",
+ """"abc"""" -> """"abc"""",
+ """'\t\n xyz \t\r'""" -> """'\t\n xyz \t\r'""",
+ "1l" -> "1L", "1S" -> "1S",
+ "date'-0001-1-28'" -> "date'-0001-1-28'",
+ "interval 3 year 1 month" -> "INTERVAL3YEAR1MONTH",
+ "x'00'" -> "x'00'",
+ // Preserve case
+ "CAST(1 as tinyint)" -> "CAST(1AStinyint)",
Review Comment:
This PR https://github.com/apache/spark/pull/40565 does this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
