dongjoon-hyun commented on code in PR #40118:
URL: https://github.com/apache/spark/pull/40118#discussion_r1151381916
##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala:
##########
@@ -202,9 +203,13 @@ private[spark] class Client(
}
}
}
- } else {
- logInfo(s"Deployed Spark application ${conf.appName} with application ID
${conf.appId} " +
- s"and submission ID $sId into Kubernetes")
+ // no-test case exit with the driver's exit code
+ if (!sys.props.get(IS_TESTING.key).getOrElse("false").toBoolean) {
+ watcher.getDriverExitCode().foreach { exitCode =>
Review Comment:
This PR seems to propose to introduce a new `SparkException` point to this
class. In general, it's not good, as you know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
