WweiL commented on code in PR #40586:
URL: https://github.com/apache/spark/pull/40586#discussion_r1153899173
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -2120,7 +2130,6 @@ class SparkConnectPlanner(val session: SparkSession) {
case StreamingQueryCommand.CommandTypeCase.EXPLAIN =>
val result = query match {
- case q: StreamExecution =>
q.explainInternal(command.getExplain.getExtended)
Review Comment:
Sorry double checked and found that the query was returned using
`StreamingQueryManager`'s `get` method, which is StreamingQuery
https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/streaming/StreamingQueryManager.scala#L106
Following existing code maybe we could change this to
`case q: StreamingQuery` and do a cast like:
https://github.com/apache/spark/blob/35503a535771d257b517e7ddf2adfaefefd97dad/sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamSuite.scala#L249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
