HyukjinKwon commented on code in PR #40607:
URL: https://github.com/apache/spark/pull/40607#discussion_r1155403938
##########
python/pyspark/ml/torch/distributor.py:
##########
@@ -176,20 +184,19 @@ def _get_num_tasks(self) -> int:
RuntimeError
Raised when the SparkConf was misconfigured.
"""
-
if self.use_gpu:
if not self.local_mode:
key = "spark.task.resource.gpu.amount"
- task_gpu_amount = int(self.sc.getConf().get(key, "0"))
+ task_gpu_amount = int(_get_conf(self.spark, key, "0"))
if task_gpu_amount < 1:
raise RuntimeError(f"'{key}' was unset, so gpu usage is
unavailable.")
# TODO(SPARK-41916): Address situation when
spark.task.resource.gpu.amount > 1
return math.ceil(self.num_processes / task_gpu_amount)
else:
key = "spark.driver.resource.gpu.amount"
- if "gpu" not in self.sc.resources:
+ if "gpu" not in self.spark.sparkContext.resources:
Review Comment:
Should probably at least comment here that it doesn't work with Spark
connect (or add a todo with a JIRA)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
