cloud-fan commented on code in PR #40623:
URL: https://github.com/apache/spark/pull/40623#discussion_r1155713419
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/SparkSession.scala:
##########
@@ -234,19 +236,24 @@ class SparkSession private[sql] (
* @param sqlText
* A SQL statement with named parameters to execute.
* @param args
- * A map of parameter names to string values that are parsed as SQL
literal expressions. For
- * example, map keys: "rank", "name", "birthdate"; map values: "1",
"'Steven'",
- * "DATE'2023-03-21'". The fragments of string values belonged to SQL
comments are skipped
- * while parsing.
+ * A map of parameter names to Java/Scala objects that can be converted to
SQL literal
+ * expressions. See <a
href="https://spark.apache.org/docs/latest/sql-ref-datatypes.html";>
+ * Supported Data Types</a> for supported value types in Scala/Java. For
example, map keys:
+ * "rank", "name", "birthdate"; map values: 1, "Steven",
LocalDate.of(2023, 4, 2). Map value
+ * can be a `Column` of literal expression, in that case it is taken as is.
Review Comment:
```suggestion
* can be also a `Column` of literal expression, in that case it is
taken as is.
```
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/SparkSession.scala:
##########
@@ -215,15 +216,16 @@ class SparkSession private[sql] (
* @param sqlText
* A SQL statement with named parameters to execute.
* @param args
- * A map of parameter names to string values that are parsed as SQL
literal expressions. For
- * example, map keys: "rank", "name", "birthdate"; map values: "1",
"'Steven'",
- * "DATE'2023-03-21'". The fragments of string values belonged to SQL
comments are skipped
- * while parsing.
+ * A map of parameter names to Java/Scala objects that can be converted to
SQL literal
+ * expressions. See <a
href="https://spark.apache.org/docs/latest/sql-ref-datatypes.html";>
+ * Supported Data Types</a> for supported value types in Scala/Java. For
example, map keys:
+ * "rank", "name", "birthdate"; map values: 1, "Steven",
LocalDate.of(2023, 4, 2). Map value
+ * can be a `Column` of literal expression, in that case it is taken as is.
Review Comment:
```suggestion
* can also be a `Column` of literal expression, in that case it is
taken as is.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
