HyukjinKwon commented on code in PR #40525:
URL: https://github.com/apache/spark/pull/40525#discussion_r1155893722
##########
python/pyspark/pandas/frame.py:
##########
@@ -7443,12 +7472,12 @@ def _prepare_sort_by_scols(self, by: Union[Name,
List[Name]]) -> List[Column]:
"The column %s is not unique. For a multi-index, the label
must be a tuple "
"with elements corresponding to each level." %
name_like_string(colname)
)
- new_by.append(ser.spark.column)
+ new_by.append(cast(GenericColumn, ser.spark.column))
return new_by
def _sort(
self,
- by: List[Column],
+ by: Sequence[GenericColumn],
Review Comment:
Why `Sequence`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
