clownxc commented on code in PR #40638:
URL: https://github.com/apache/spark/pull/40638#discussion_r1155932178
##########
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2Suite.scala:
##########
@@ -905,6 +908,13 @@ object ColumnarReaderFactory extends
PartitionReaderFactory {
override def supportColumnarReads(partition: InputPartition): Boolean = true
+ override def getVectorTypes: Optional[java.lang.Iterable[String]] = {
+ val data: Iterable[String] = Iterable.fill(2)(
+ classOf[OnHeapColumnVector].getName
+ )
Review Comment:
> Oh, that's also very nice (re my previous comment to use
`Collections.nCopies`).
>
> Can you rename `data`?
Thank you, I will try to modify the code as you say
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
