amaliujia commented on code in PR #40586:
URL: https://github.com/apache/spark/pull/40586#discussion_r1156243044
##########
connector/connect/common/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -154,6 +158,9 @@ message Read {
//
// This is only supported by the JDBC data source.
repeated string predicates = 5;
+
+ // (Optional) Source table name for a streaming read. Not used in batch
read.
+ string streaming_table_name = 6;
Review Comment:
```
message NamedTable {
// (Required) Unparsed identifier for the table.
string unparsed_identifier = 1;
// Options for the named table. The map key is case insensitive.
map<string, string> options = 2;
}
```
NamedTable was fixed to support options now. But it is ok to migrate to that
later given that this PR is already at a good shape.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
