itholic commented on code in PR #40525:
URL: https://github.com/apache/spark/pull/40525#discussion_r1156657940
##########
python/pyspark/pandas/data_type_ops/base.py:
##########
@@ -470,14 +474,16 @@ def eq(self, left: IndexOpsLike, right: Any) ->
SeriesOrIndex:
else:
from pyspark.pandas.base import column_op
- return column_op(Column.__eq__)(left, right)
+ Column = ConnectColumn if is_remote() else PySparkColumn
+ return column_op(cast(Callable[..., GenericColumn],
Column.__eq__))(left, right)
Review Comment:
Sounds good. Then we even don't need `cast`. Let me apply the changes
through whole changes.
##########
python/pyspark/pandas/data_type_ops/base.py:
##########
@@ -470,14 +474,16 @@ def eq(self, left: IndexOpsLike, right: Any) ->
SeriesOrIndex:
else:
from pyspark.pandas.base import column_op
- return column_op(Column.__eq__)(left, right)
+ Column = ConnectColumn if is_remote() else PySparkColumn
+ return column_op(cast(Callable[..., GenericColumn],
Column.__eq__))(left, right)
Review Comment:
Sounds good. Then seems like we even don't need `cast` here. Let me apply
the changes through whole changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
