Kimahriman commented on code in PR #34558:
URL: https://github.com/apache/spark/pull/34558#discussion_r1157743929
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala:
##########
@@ -101,6 +101,14 @@ case class NamedLambdaVariable(
override def simpleString(maxFields: Int): String = {
s"lambda $name#${exprId.id}: ${dataType.simpleString(maxFields)}"
}
+
+ // We need to include the Expr ID in the Codegen variable name since several
tests bypass
+ // `UnresolvedNamedLambdaVariable.freshVarName`
+ lazy val variableName = s"${name}_${exprId.id}"
Review Comment:
Hmm must have thought it was used in the actual generated code or something
but doesn't look like it is. In fact I don't think `variableName` is really
needed at all, can just use `exprId.id` as the map key, and `name` for the code
comment
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala:
##########
@@ -350,6 +445,49 @@ case class ArrayTransform(
result
}
+ override def doGenCode(ctx: CodegenContext, ev: ExprCode): ExprCode = {
+ ctx.withLambdaVars(Seq(elementVar) ++ indexVar, { lambdaExprs =>
Review Comment:
I think I did that because of the instances where I used the case expression
to pull out the single element list, will update these for consistency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
