cloud-fan commented on code in PR #40651:
URL: https://github.com/apache/spark/pull/40651#discussion_r1157924616
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/percentiles.scala:
##########
@@ -155,7 +156,7 @@ abstract class PercentileBase
}
val ordering = child.dataType match {
Review Comment:
What's the benefit of having `OrderedPhysicalDataType` and complicating the
hierarchy of `PhysicalDataType`? Most callers just patter match some data types
and fail for unexpected data types. It's simpler to make some physical types
fail when overriding `ordering`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
