HyukjinKwon commented on code in PR #40673:
URL: https://github.com/apache/spark/pull/40673#discussion_r1158140990


##########
.github/workflows/build_and_test.yml:
##########
@@ -494,53 +495,12 @@ jobs:
         name: test-results-sparkr--8-${{ inputs.hadoop }}-hive2.3
         path: "**/target/test-reports/*.xml"
 
-  proto-breaking-changes-check-master:
+  breaking-changes-buf:
     needs: [precondition]
-    if: always() && 
fromJson(needs.precondition.outputs.required).proto-breaking-changes-check == 
'true'
-    name: Spark Connect proto backwards compatibility check (master)
-    continue-on-error: true
+    if: always() && 
fromJson(needs.precondition.outputs.required).breaking-changes-buf == 'true'
+    # Change 'branch-3.4' to 'branch-3.5' in master branch after cutting 
branch-3.5 branch.
+    name: Breaking change detection with Buf (branch-3.4)

Review Comment:
   This name, I got it from 
https://github.com/bufbuild/buf-breaking-action#buf-breaking-action README.md



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to