itholic commented on code in PR #40672:
URL: https://github.com/apache/spark/pull/40672#discussion_r1159217645


##########
python/pyspark/errors/exceptions/connect.py:
##########
@@ -46,40 +46,56 @@ class SparkConnectException(PySparkException):
 
 def convert_exception(info: "ErrorInfo", message: str) -> 
SparkConnectException:
     classes = []
+    error_class = None
+    message_parameters = None
+    # TODO: add sqlState in PySparkException.

Review Comment:
   I believe that since `PySparkException` manages errors that are specifically 
raised by PySpark (not JVM), maybe there is no need to add `sqlState` to it.
   The SQLSTATE of errors that occur in the JVM already can be obtained through 
the `getSqlState`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to