vicennial commented on code in PR #40675: URL: https://github.com/apache/spark/pull/40675#discussion_r1159690669
########## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/SparkSession.scala: ########## @@ -488,6 +488,14 @@ class SparkSession private[sql] ( @scala.annotation.varargs def addArtifacts(uri: URI*): Unit = client.addArtifacts(uri) + /** + * Register a [[ClassFinder]] for dynamically generated classes. + * + * @since 3.4.0 + */ + @Experimental Review Comment: > Also mark @Private? Wrt the above comment, we can't since we register the class finder as part of the predef code. I'm not too well versed with Ammonite internals, I wonder if we can get the REPL session without having to go through predef code. ########## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/SparkSession.scala: ########## @@ -488,6 +488,14 @@ class SparkSession private[sql] ( @scala.annotation.varargs def addArtifacts(uri: URI*): Unit = client.addArtifacts(uri) + /** + * Register a [[ClassFinder]] for dynamically generated classes. + * + * @since 3.4.0 + */ + @Experimental Review Comment: > Also mark @Private? Wrt the above comment, we can't since we register the class finder as part of the predef code. I'm not too well versed with Ammonite internals, I wonder if we can get the REPL session without having to go through predef code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
