cloud-fan commented on code in PR #40662:
URL: https://github.com/apache/spark/pull/40662#discussion_r1159780157
##########
sql/core/src/test/resources/tpcds-plan-stability/approved-plans-v1_4/q1.sf100/simplified.txt:
##########
@@ -38,7 +38,7 @@ TakeOrderedAndProject [c_customer_id]
BroadcastExchange #4
WholeStageCodegen (6)
Filter [(avg(ctr_total_return) * 1.2)]
- HashAggregate [ctr_store_sk,sum,count]
[avg(ctr_total_return),(avg(ctr_total_return) * 1.2),ctr_store_sk,sum,count]
+ HashAggregate [ctr_store_sk,sum,count]
[avg(ctr_total_return),(avg(ctr_total_return) * 1.2),sum,count]
Review Comment:
The change is caused by the removal of a useless alias due to deduplicated
attr id:
https://github.com/apache/spark/pull/40662/files#diff-d4cb11a6b81481952eb2af8e3a546cd5e2f01cd5f9453c62a785570abe134b5aR159
The plan string in the golden file is not grouping expressions + aggregate
expressions, but references + produced attributes, see
https://github.com/apache/spark/blob/master/sql/core/src/test/scala/org/apache/spark/sql/PlanStabilitySuite.scala#L214-L219
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
