hvanhovell commented on code in PR #40352:
URL: https://github.com/apache/spark/pull/40352#discussion_r1160394607
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -1154,6 +1155,91 @@ class SparkConnectPlanner(val session: SparkSession) {
}
Some(Lead(children.head, children(1), children(2), ignoreNulls))
+ case "bloom_filter_agg" if fun.getArgumentsCount == 5 =>
+ // [col, catalogString: String, expectedNumItems: Long, numBits: Long,
fpp: Double]
+ val children =
fun.getArgumentsList.asScala.toSeq.map(transformExpression)
+ val dt = {
+ val ddl = children(1) match {
+ case StringLiteral(s) => s
+ case other =>
+ throw InvalidPlanInput(s"col dataType should be a literal
string, but got $other")
+ }
+ DataType.fromDDL(ddl)
+ }
+ val col = dt match {
Review Comment:
I wonder if we can solve this by special casing implicit type conversions in
BloomFilterAggregate instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
