beliefer commented on PR #40563: URL: https://github.com/apache/spark/pull/40563#issuecomment-1499895556
> After a second thought, this makes the performance worse. We should improve `ArrayInsert` to generate more efficient code if the position argument is constant. For example, if the position argument is constant 1, then we don't need to generate code to check if position is negative or not. You means create another PR to simplify the code of `ArrayInsert`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
