yaooqinn commented on code in PR #40683:
URL: https://github.com/apache/spark/pull/40683#discussion_r1160416286
##########
connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/OracleIntegrationSuite.scala:
##########
@@ -106,17 +106,26 @@ class OracleIntegrationSuite extends
DockerJDBCIntegrationV2Suite with V2JDBCTes
var t = spark.table(tbl)
var expectedSchema = new StructType().add("ID", DecimalType(10, 0), true,
defaultMetadata)
assert(t.schema === expectedSchema)
- sql(s"ALTER TABLE $tbl ALTER COLUMN id TYPE STRING")
+ sql(s"ALTER TABLE $tbl ALTER COLUMN id TYPE LONG")
t = spark.table(tbl)
- expectedSchema = new StructType().add("ID", StringType, true,
defaultMetadata)
+ expectedSchema = new StructType().add("ID", DecimalType(19, 0), true,
defaultMetadata)
Review Comment:
Yes, Oracle Built-in integrals are `NUMBER(p, 0)`, the `LONG` there is a
deprecated alternative for character strings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
