cloud-fan commented on code in PR #40523:
URL: https://github.com/apache/spark/pull/40523#discussion_r1160456984
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashJoinExec.scala:
##########
@@ -364,10 +364,18 @@ case class ShuffledHashJoinExec(
|${streamedKeyExprCode.code}
""".stripMargin
val streamedKeyAnyNull = s"${streamedKeyExprCode.value}.anyNull()"
-
+ // The streamedVars may be evaluated again in the following
consumeFullOuterJoinRow method,
+ // so generate the condition checking code with their copies.
Review Comment:
```suggestion
// so generate the condition checking code with their copies, to avoid
side effects (ExprCode is mutable).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
