Yikf commented on PR #40437: URL: https://github.com/apache/spark/pull/40437#issuecomment-1500012982
> > Spark generates golden files for SQLQueryTestSuite; > > I think golden files there should match `df.show` instead of hive result. This may be a bit of a regression, maybe... first, golden generation and validation are done with `hiveResultString `, it won't have what problem, then, the output is more readable, finally, `ThriftServerQueryTestSuite` test case generation also uses the independent `hiveString`, this also needs to reconstruct. So what's the benefit of removal? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
