gengliangwang commented on code in PR #40710:
URL: https://github.com/apache/spark/pull/40710#discussion_r1161009871
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveDefaultColumns.scala:
##########
@@ -91,6 +90,25 @@ case class ResolveDefaultColumns(catalog: SessionCatalog)
extends Rule[LogicalPl
}
}
+ /**
+ * Checks if a logical plan is an INSERT INTO command where the inserted
data comes from a SELECT
+ * list, with possible other unary operators like sorting and/or alias(es)
in between.
+ */
+ private def insertsFromProject(i: InsertIntoStatement): Option[Project] = {
+ var node = i.query
+ def matches(node: LogicalPlan): Boolean = node match {
+ case _: GlobalLimit | _: LocalLimit | _: Offset | _: SubqueryAlias | _:
Sort => true
+ case _ => false
+ }
+ while (matches(node)) {
+ node = node.children.head
Review Comment:
Why getting the first child only? What if there is a join and one of the
children has a project containing default?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
