amaliujia commented on code in PR #40693:
URL: https://github.com/apache/spark/pull/40693#discussion_r1161167873
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala:
##########
@@ -915,9 +916,9 @@ case class Cast(
case TimestampType =>
buildCast[Long](_, t => timestampToLong(t))
case x: NumericType if ansiEnabled =>
- b => x.exactNumeric.asInstanceOf[Numeric[Any]].toLong(b)
+ b => PhysicalNumericType.exactNumeric(x).toLong(b)
Review Comment:
Well after reading the code, I think we need to expland `NumericType` to all
its sub-class and find the numeric directly to avoid
`PhysicalNumericType.exactNumeric(x)`.
This is because we do not know the running type in advance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
