LuciferYang commented on code in PR #40719:
URL: https://github.com/apache/spark/pull/40719#discussion_r1162874759
##########
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedRleValuesReader.java:
##########
@@ -928,11 +956,35 @@ private boolean readNextGroup() {
}
currentBufferIdx = 0;
int valueIndex = 0;
- while (valueIndex < this.currentCount) {
- // values are bit packed 8 at a time, so reading bitWidth will
always work
- ByteBuffer buffer = in.slice(bitWidth);
- this.packer.unpack8Values(buffer, buffer.position(),
this.currentBuffer, valueIndex);
- valueIndex += 8;
+ if (vector512Support && SQLConf.get().parquetVector512Read()) {
Review Comment:
It seems that there is currently no corresponding UTs, and if not all GA
machines can be used to check this part, how can we continue to ensure its
robustness?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
