cloud-fan commented on code in PR #40734:
URL: https://github.com/apache/spark/pull/40734#discussion_r1163845948


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala:
##########
@@ -389,6 +389,46 @@ case class WriteDelta(
   }
 }
 
+trait V2CreateTableAsSelectPlan extends Command with V2CreateTablePlan with 
KeepAnalyzedQuery {

Review Comment:
   `KeepAnalyzedQuery` is for commands that need both analyzed and optimized 
plan. V2 write commands use it because if v1 fallback is not needed, we still 
need the optimized plan.
   
   For CTAS/RTAS, we don't need the optimized plan at all. I think 
`AnalysisOnlyCommand` is a better fit here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to