zhengruifeng commented on code in PR #40750:
URL: https://github.com/apache/spark/pull/40750#discussion_r1163838955


##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectStreamHandler.scala:
##########
@@ -52,19 +52,15 @@ class SparkConnectStreamHandler(responseObserver: 
StreamObserver[ExecutePlanResp
     session.withActive {
 
       // Add debug information to the query execution so that the jobs are 
traceable.
-      try {

Review Comment:
   yes, I added it for that PyTorch test case, in which the size of UDF is 47mb 
and cause OOM
   
   but I am not very sure whether there are some other unknown edge cases that 
can also cause failure, so I personally prefer adding the try-catch back before 
merge it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to