cloud-fan commented on code in PR #39170: URL: https://github.com/apache/spark/pull/39170#discussion_r1163910679
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/InjectRuntimeFilter.scala: ########## @@ -114,51 +115,89 @@ object InjectRuntimeFilter extends Rule[LogicalPlan] with PredicateHelper with J } /** - * Returns whether the plan is a simple filter over scan and the filter is likely selective + * Extracts the plan exists a simple filter over scan and the filter is likely selective Review Comment: ``` Extracts a sub-plan which is a simple filter over scan from the input plan. The simple filter should be selective and the filter condition (including expressions in the child plan referenced by the filter condition) should be a simple expression, so that we do not add a subquery that might have an expensive computation. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
