beliefer commented on code in PR #40754:
URL: https://github.com/apache/spark/pull/40754#discussion_r1163992394
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowGroupLimitExec.scala:
##########
@@ -116,7 +129,8 @@ abstract class BaseLimitIterator extends
Iterator[InternalRow] {
case class SimpleLimitIterator(
input: Iterator[InternalRow],
- limit: Int) extends BaseLimitIterator {
+ limit: Int,
+ numOutputRows: SQLMetric) extends BaseLimitIterator {
Review Comment:
Could we avoid it as parameter ?
It seems just put
```
override lazy val metrics = Map(
"numOutputRows" -> SQLMetrics.createMetric(sparkContext, "number of
output rows"))
```
into BaseLimitIterator directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
