dongjoon-hyun commented on code in PR #40645:
URL: https://github.com/apache/spark/pull/40645#discussion_r1164416835
##########
core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala:
##########
@@ -904,7 +904,12 @@ private[spark] class SparkSubmit extends Logging {
childArgs ++= Seq("--verbose")
}
- sparkConf.set("spark.app.submitTime", System.currentTimeMillis().toString)
+ val setSubmitTimeInClusterModeDriver =
+ sparkConf.getBoolean("spark.kubernetes.setSubmitTimeInDriver", false)
Review Comment:
When we introduce a new feature, we hide it first at least for a single
Apache Spark release in order to provide a testing capability without the
default behavior changes. In other words, this should be `true`.
```scala
- sparkConf.getBoolean("spark.kubernetes.setSubmitTimeInDriver", false)
- sparkConf.getBoolean("spark.kubernetes.setSubmitTimeInDriver", true)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
