amaliujia commented on code in PR #40763:
URL: https://github.com/apache/spark/pull/40763#discussion_r1164796991
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercionSuite.scala:
##########
@@ -1763,6 +1763,8 @@ object TypeCoercionSuite {
Seq(DoubleType, FloatType, DecimalType.SYSTEM_DEFAULT, DecimalType(10, 2))
val numericTypes: Seq[DataType] = integralTypes ++ fractionalTypes
val datetimeTypes: Seq[DataType] = Seq(DateType, TimestampType,
TimestampNTZType)
+ val intervalTypes: Seq[DataType] = Seq(CalendarIntervalType,
DayTimeIntervalType.DEFAULT,
+ YearMonthIntervalType.DEFAULT)
Review Comment:
nit: I am thinking you should use `defaultConcreteType` to access the
DEFAULT instance:
https://github.com/apache/spark/blob/76bd695084ca8564bdca258b469ece54d3a55ab0/sql/catalyst/src/main/scala/org/apache/spark/sql/types/DayTimeIntervalType.scala#L106
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
