Hisoka-X commented on code in PR #40741:
URL: https://github.com/apache/spark/pull/40741#discussion_r1164870257
##########
connector/connect/common/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -111,6 +111,9 @@ message SQL {
// (Optional) A map of parameter names to literal expressions.
map<string, Expression.Literal> args = 2;
+
+ // (Optional) A map of parameter names to column expressions.
+ map<string, Expression.UnresolvedAttribute> columns = 3;
Review Comment:
There are some different between args and columns. `SELECT {col} FROM t1
WHERE id=1` , the `{col}` used for `columns`. `SELECT id FROM t1 WHERE id=
:value `, the `:value` used for `args`. The symbols used by the two are
different, and the processing logic is also different. `{col}` is replaced
before SQL analysis, and args is value replacement done in SQL analysis.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
