cloud-fan commented on code in PR #40734:
URL: https://github.com/apache/spark/pull/40734#discussion_r1164878700
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala:
##########
@@ -389,6 +389,42 @@ case class WriteDelta(
}
}
+trait V2CreateTableAsSelectPlan extends V2CreateTablePlan with
AnalysisOnlyCommand {
+ def name: LogicalPlan
Review Comment:
since we are doing some refactoring here, shall we move `def name` to
`V2CreateTablePlan`? Then we can move the implementation of `def tableName` to
`V2CreateTablePlan` as well to further deduplicate code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]