rangadi commented on code in PR #40783: URL: https://github.com/apache/spark/pull/40783#discussion_r1165910903
########## connector/connect/client/jvm/src/main/java/org/apache/spark/sql/streaming/Trigger.java: ########## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.streaming; Review Comment: This file is copied from spark-sql package. Client does not include spark-sql in its dependencies. ########## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/SparkSession.scala: ########## @@ -453,11 +466,12 @@ class SparkSession private[sql] ( client.execute(plan).asScala.foreach(_ => ()) } - private[sql] def execute(command: proto.Command): Unit = { + private[sql] def execute(command: proto.Command): Seq[ExecutePlanResponse] = { Review Comment: This is updated to return the responses for the command. ########## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/streaming/StreamingQuery.scala: ########## @@ -0,0 +1,316 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.streaming + +import java.util.UUID +import java.util.concurrent.TimeoutException + +import scala.collection.JavaConverters._ + +import org.apache.spark.annotation.Evolving +import org.apache.spark.connect.proto.Command +import org.apache.spark.connect.proto.ExecutePlanResponse +import org.apache.spark.connect.proto.StreamingQueryCommand +import org.apache.spark.connect.proto.StreamingQueryCommandResult +import org.apache.spark.connect.proto.StreamingQueryInstanceId +import org.apache.spark.sql.SparkSession + +/** + * A handle to a query that is executing continuously in the background as new data arrives. + * All these methods are thread-safe. + * @since 3.5.0 + */ +@Evolving +trait StreamingQuery { Review Comment: This trait is copied unmodified from spark-sql. See `RemoteStreamingQuery` bellow for the actual implementation. ########## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/streaming/StreamingQueryStatus.scala: ########## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.streaming + +import org.json4s._ +import org.json4s.JsonAST.JValue +import org.json4s.JsonDSL._ +import org.json4s.jackson.JsonMethods._ + +import org.apache.spark.annotation.Evolving + +/** + * Reports information about the instantaneous status of a streaming query. + * + * @param message A human readable description of what the stream is currently doing. + * @param isDataAvailable True when there is new data to be processed. Doesn't apply + * to ContinuousExecution where it is always false. + * @param isTriggerActive True when the trigger is actively firing, false when waiting for the + * next trigger time. Doesn't apply to ContinuousExecution where it is + * always false. + * + * @since 3.5.0 + */ +@Evolving +class StreamingQueryStatus protected[sql]( Review Comment: This is copied as-is from spark-sql. ########## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/execution/streaming/Triggers.scala: ########## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.execution.streaming Review Comment: Copied from spark-sql directory. No other changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
