tianhanhu-db commented on code in PR #40678:
URL: https://github.com/apache/spark/pull/40678#discussion_r1166162783
##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala:
##########
@@ -104,6 +105,31 @@ abstract class JdbcDialect extends Serializable with
Logging {
*/
def getJDBCType(dt: DataType): Option[JdbcType] = None
+ /**
+ * Convert java.sql.Timestamp to a LocalDateTime representing the same
wall-clock time as the
+ * value stored in a remote database.
+ * JDBC dialects should override this function to provide implementations
that suite their
+ * JDBC drivers.
+ * @param t Timestamp returned from JDBC driver getTimestamp method.
+ * @return A LocalDateTime representing the same wall clock time as the
timestamp in database.
+ */
+ @Since("3.5.0")
+ def convertJavaTimestampToTimestampNTZ(t: Timestamp): LocalDateTime = {
+
DateTimeUtils.microsToLocalDateTime(DateTimeUtils.fromJavaTimestampNoRebase(t))
Review Comment:
I think I am missing something here.
"`DateTimeUtils.fromJavaTimestampNoRebase(t)` only" would result in a Long
value, where we wish for a `LocalDateTime` as the return type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
