LuciferYang commented on PR #40792: URL: https://github.com/apache/spark/pull/40792#issuecomment-1508799437
Manually run `dev/sbt-checkstyle` can reproduce, but it seems that `dev/sbt-checkstyle` does not always execute. https://github.com/apache/spark/blob/4c938d62d791742b9f0c6a77b66fc06a90d7c0ad/dev/run-tests.py#L611-L616 https://github.com/apache/spark/blob/4c938d62d791742b9f0c6a77b66fc06a90d7c0ad/dev/run-tests.py#L641-L647 `lint-java` use mvn checkstyle, It did not checked error. So should we let `lint-java` use `sbt-checkstyle` to unify behavior? Additionally, it seems that the generated proto java files of the connect-common module have not been checked? it is a little strange. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
