Yikf commented on PR #40437:
URL: https://github.com/apache/spark/pull/40437#issuecomment-1508909227
@cloud-fan This PR currently makes spark-sql CLI use the same spark result
string as df.show.
And remove the use of hiveResultString by non-HiveComparisonTest. Like
ExpressionInfoSuite, currently, only SQLQueryTestHelper and HiveComparisonTest
use hiveResultString, and SQLQueryTestHelper is used for golden file
generation. I try to make SQLQueryTestHelper also use sparkResultString, but
ThriftServerQueryTestSuite also uses golden files.
And Beautify the output of cast StructType to StringType, Such as {1, 2} ->
{a:1, b:2}. (It has nothing to do with the theme of this PR, Just in passing
when making ExpressionInfoSuite to use sparkResultString, If you mind, I can
send another PR to do this).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
