RyanBerti commented on PR #40615: URL: https://github.com/apache/spark/pull/40615#issuecomment-1509053727
Hello @mkaravel ! I've updated the PR to provide the following functions: Aggregate functions: - hll_sketch_agg(IntegerType|LongType|StringType|BinaryType) -> BinaryType - hll_union_agg(BinaryType) -> BinaryType Scalar functions - hll_sketch_estimate(BinaryType) -> LongType - hll_union(BinaryType, BinaryType) -> BinaryType Naming wise, I felt it was valuable to keep the function names aligned with the Datasketches objects they utilize, and be explicit about the operation being applied. Hopefully these function names are a good middle ground for us? I'll continue working on getting all the tests to pass, and then open the PR up for wide review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
