warrenzhu25 commented on code in PR #40730:
URL: https://github.com/apache/spark/pull/40730#discussion_r1168056488


##########
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala:
##########
@@ -401,17 +403,24 @@ private[spark] class TaskSchedulerImpl(
       val host = shuffledOffers(i).host
       val taskSetRpID = taskSet.taskSet.resourceProfileId
 
+      var continueScheduling = true
       // check whether the task can be scheduled to the executor base on 
resource profile.
-      if (sc.resourceProfileManager
-        .canBeScheduled(taskSetRpID, shuffledOffers(i).resourceProfileId)) {
+      while (sc.resourceProfileManager

Review Comment:
   Scheduling policy such as FIFO or Fair is using single task set as schedule 
unit. My change is inside `resourceOfferSingleTaskSet`, which not change how 
task set is scheduled.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to