LuciferYang commented on code in PR #40783: URL: https://github.com/apache/spark/pull/40783#discussion_r1168306284
########## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/streaming/DataStreamReader.scala: ########## @@ -0,0 +1,275 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.streaming + +import scala.collection.JavaConverters._ + +import org.apache.spark.annotation.Evolving +import org.apache.spark.connect.proto.Read.DataSource +import org.apache.spark.sql.DataFrame +import org.apache.spark.sql.Dataset +import org.apache.spark.sql.SparkSession +import org.apache.spark.sql.types.StructType + +/** + * Interface used to load a streaming `Dataset` from external storage systems (e.g. file systems, + * key-value stores, etc). Use `SparkSession.readStream` to access this. + * + * @since 3.5.0 + */ +@Evolving +final class DataStreamReader private[sql] (sparkSession: SparkSession) { + + /** + * Specifies the input data source format. + * + * @since 3.5.0 + */ + def format(source: String): DataStreamReader = { + sourceBuilder.setFormat(source) + this + } + + /** + * Specifies the input schema. Some data sources (e.g. JSON) can infer the input schema + * automatically from data. By specifying the schema here, the underlying data source can skip + * the schema inference step, and thus speed up data loading. + * + * @since 3.5.0 + */ + def schema(schema: StructType): DataStreamReader = { + if (schema != null) { + sourceBuilder.setSchema(schema.json) // Use json. DDL does not retail all the attributes. Review Comment: not related to the current pr. https://github.com/apache/spark/blob/045721967f31a39e9227a951774d7250a6be14dc/connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/DataFrameReader.scala#L184 Should the above code also use `schema.json`? I remember having pr discuss this , Do you have any impression of what the conclusion is @zhenlineo ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
