Hisoka-X commented on code in PR #40823:
URL: https://github.com/apache/spark/pull/40823#discussion_r1168891859
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/ParseDriver.scala:
##########
@@ -127,7 +127,7 @@ abstract class AbstractSqlParser extends ParserInterface
with SQLConfHelper with
toResult(parser)
}
catch {
- case e: ParseCancellationException =>
+ case _: ParseCancellationException | _: ParseException =>
Review Comment:
Thanks for remind. The `SparkParserErrorStrategy` will rewrap Exception
which throw by antlr4. And finally throw it by `ParseException`. So if we want
to fix this, catch `ParserException` will be a way. If you have any better idea
please let me know. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
