LuciferYang commented on code in PR #40837:
URL: https://github.com/apache/spark/pull/40837#discussion_r1169797634
##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/ClientE2ETestSuite.scala:
##########
@@ -193,6 +193,7 @@ class ClientE2ETestSuite extends RemoteSparkSession with
SQLHelper {
}
test("write jdbc") {
+ assume(IntegrationTestUtils.isSparkHiveJarAvailable)
Review Comment:
`derby.jar` will only be copied to `assembly/target/scala-xxx/jars/` when
build with -Phive, so there check `isSparkHiveJarAvailable`, maybe a little
trick.
Another way is to check if `derby-xxx.jar` is in the
`assembly/target/scala-xxx/jars/` directory.
##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/ClientE2ETestSuite.scala:
##########
@@ -193,6 +193,7 @@ class ClientE2ETestSuite extends RemoteSparkSession with
SQLHelper {
}
test("write jdbc") {
+ assume(IntegrationTestUtils.isSparkHiveJarAvailable)
Review Comment:
`derby.jar` will only be copied to `assembly/target/scala-xxx/jars/` when
build with `-Phive`, so there check `isSparkHiveJarAvailable`, maybe a little
trick.
Another way is to check if `derby-xxx.jar` is in the
`assembly/target/scala-xxx/jars/` directory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
