WweiL commented on PR #40780: URL: https://github.com/apache/spark/pull/40780#issuecomment-1513609314
> > @Hisoka-X I think we also change this line? https://github.com/apache/spark/pull/40780/files#diff-d21a96890e660df398527183a191b0d0c73521aada856e2491c33243f269fdceR128 > > I could add it to my ongoing PR #40785 > > OK for me, but I just want to remind, add null check just want to avoid throw NPE in `setMessage`, not want to change `null` to `""` I see. With additional look I think here it's better to keep what it is. as Status's description is nullable: ``` private Status(Code code, @Nullable String description, @Nullable Throwable cause) { this.code = checkNotNull(code, "code"); this.description = description; this.cause = cause; } public Status withDescription(String description) { if (Objects.equal(this.description, description)) { return this; } return new Status(this.code, description, this.cause); } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
