grundprinzip commented on code in PR #40853:
URL: https://github.com/apache/spark/pull/40853#discussion_r1171329246
##########
python/pyspark/sql/connect/client.py:
##########
@@ -269,18 +269,9 @@ def userAgent(self) -> str:
user_agent : str
The user_agent parameter specified in the connection string,
or "_SPARK_CONNECT_PYTHON" when not specified.
+ The returned value will be percent encoded.
"""
- user_agent = self.params.get(ChannelBuilder.PARAM_USER_AGENT,
"_SPARK_CONNECT_PYTHON")
- allowed_chars = string.ascii_letters + string.punctuation
- if len(user_agent) > 200:
Review Comment:
should we not assert on some length? maybe 1204?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
