xinrong-meng commented on code in PR #40729:
URL: https://github.com/apache/spark/pull/40729#discussion_r1171665334
##########
connector/connect/common/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -838,6 +841,12 @@ message CoGroupMap {
// (Required) Input user-defined function.
CommonInlineUserDefinedFunction func = 5;
+
+ // (Optional) Expressions for sorting. Only used by Scala Sorted CoGroup Map
API.
+ repeated Expression input_sorting_expressions = 6;
Review Comment:
When there is only one relation involved, we name it `input` by convention.
Thus, an additional relation is named `other`. I don't have an objection if
you prefer renaming. I would suggest minimizing changes to existing proto
though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
