cloud-fan commented on code in PR #39950:
URL: https://github.com/apache/spark/pull/39950#discussion_r1172104789
##########
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/SpecificParquetRecordReaderBase.java:
##########
@@ -89,16 +90,27 @@
@Override
public void initialize(InputSplit inputSplit, TaskAttemptContext
taskAttemptContext)
throws IOException, InterruptedException {
+ initialize(inputSplit, taskAttemptContext, Option.empty());
+ }
+
+ public void initialize(
+ InputSplit inputSplit,
+ TaskAttemptContext taskAttemptContext,
+ Option<ParquetMetadata> fileFooter) throws IOException,
InterruptedException {
Review Comment:
do we need to use `Option`? The argument value is always `Some`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
