cloud-fan commented on code in PR #40794:
URL: https://github.com/apache/spark/pull/40794#discussion_r1172347361
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/dsl/package.scala:
##########
@@ -271,7 +271,7 @@ package object dsl {
override def expr: Expression = Literal(s)
def attr: UnresolvedAttribute = analysis.UnresolvedAttribute(s)
}
- implicit class DslAttr(attr: UnresolvedAttribute) extends
ImplicitAttribute {
+ implicit class DslAttr(override val attr: UnresolvedAttribute) extends
ImplicitAttribute {
def s: String = attr.name
Review Comment:
I think dsl attribute only supports single part name, because
`ImplicitAttribute.boolean` directly use the name to create
`AttributeReference`. That said, the `def s` here should be
```
def s: String = {
assert(attr.nameParts.length == 1)
attr.nameParts.head
}
```
and `ImplicitAttribute.attr` should be updated to
```
def attr: UnresolvedAttribute = analysis.UnresolvedAttribute(Seq(s))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
