RyanBerti commented on code in PR #40615: URL: https://github.com/apache/spark/pull/40615#discussion_r1172949405
########## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/aggregate/DatasketchesHllSketchSuite.scala: ########## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.catalyst.expressions.aggregate + +import scala.collection.immutable.NumericRange +import scala.util.Random + +import org.apache.datasketches.hll.HllSketch +import org.apache.datasketches.memory.Memory + +import org.apache.spark.SparkFunSuite +import org.apache.spark.sql.catalyst.InternalRow +import org.apache.spark.sql.catalyst.expressions.{BoundReference, HllSketchEstimate} +import org.apache.spark.sql.types.{BinaryType, DataType, IntegerType, LongType, StringType} +import org.apache.spark.unsafe.types.UTF8String + + +class DatasketchesHllSketchSuite extends SparkFunSuite { Review Comment: > Same for the register size (although I think it should go away from the API wherever it appears). Looks like [the Druid implementation supports specifying tgtHllType](https://druid.apache.org/docs/latest/development/extensions-core/datasketches-hll.html), though [the original Hive UDFs don't](https://datasketches.apache.org/docs/HLL/HllHiveUDFs.html). Can you clarify why you don't think register size should be configurable in this implementation? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
