jaceklaskowski commented on code in PR #40638:
URL: https://github.com/apache/spark/pull/40638#discussion_r1172969651
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/read/PartitionReaderFactory.java:
##########
@@ -36,33 +37,42 @@
public interface PartitionReaderFactory extends Serializable {
/**
- * Returns a row-based partition reader to read data from the given {@link
InputPartition}.
+ * @return a row-based partition reader to read data from the given {@link
InputPartition}.
Review Comment:
nit: A (uppercase)
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/read/PartitionReaderFactory.java:
##########
@@ -36,33 +37,42 @@
public interface PartitionReaderFactory extends Serializable {
/**
- * Returns a row-based partition reader to read data from the given {@link
InputPartition}.
+ * @return a row-based partition reader to read data from the given {@link
InputPartition}.
* <p>
- * Implementations probably need to cast the input partition to the concrete
- * {@link InputPartition} class defined for the data source.
+ * @note Implementations probably need to cast the input partition to the
concrete
+ * {@link InputPartition} class defined for the data source.
*/
PartitionReader<InternalRow> createReader(InputPartition partition);
/**
- * Returns a columnar partition reader to read data from the given {@link
InputPartition}.
+ * @return a columnar partition reader to read data from the given {@link
InputPartition}.
Review Comment:
Same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
