cloud-fan commented on code in PR #40889:
URL: https://github.com/apache/spark/pull/40889#discussion_r1173242572
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -925,7 +925,7 @@ class Analyzer(override val catalogManager: CatalogManager)
if (metaCols.isEmpty) {
node
} else {
- val newNode = addMetadataCol(node)
+ val newNode = node.mapChildren(addMetadataCol(_,
metaCols.map(_.exprId).toSet))
Review Comment:
This looks correct to me because we need to propagate metadata cols to this
node and need to add metadata cols in its children. Does master branch have the
same code here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
