cloud-fan commented on code in PR #40902:
URL: https://github.com/apache/spark/pull/40902#discussion_r1174341668
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/dsl/package.scala:
##########
@@ -271,8 +271,9 @@ package object dsl {
override def expr: Expression = Literal(s)
def attr: UnresolvedAttribute = analysis.UnresolvedAttribute(s)
}
- implicit class DslAttr(attr: UnresolvedAttribute) extends
ImplicitAttribute {
- def s: String = attr.name
+ implicit class DslAttr(a: UnresolvedAttribute) extends ImplicitAttribute {
+ def s: String = a.name
+ override def attr: UnresolvedAttribute = a
Review Comment:
overriding `attr` in `DslAttr` is just an optimization to avoid the
roundtrip, but it does not fix the problem, just hides it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
