ulysses-you commented on code in PR #40915: URL: https://github.com/apache/spark/pull/40915#discussion_r1174712947
########## sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/ObjectAggregationIterator.scala: ########## @@ -144,8 +136,7 @@ class ObjectAggregationIterator( // This function is used to read and process input rows. When processing input rows, it first uses // hash-based aggregation by putting groups and their buffers in `hashMap`. If `hashMap` grows too - // large, it sorts the contents, spills them to disk, and creates a new map. At last, all sorted - // spills are merged together for sort-based aggregation. + // large, it destroys the `hashMap` and falls back to sort-based aggregation. Review Comment: it's not related to this pr, but a wrong comment for a long time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
